Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): support multi statements in mysql backend #8395

Merged
merged 16 commits into from
Mar 15, 2023
Merged

sink(ticdc): support multi statements in mysql backend #8395

merged 16 commits into from
Mar 15, 2023

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #8057

What is changed and how it works?

  • Support execute multi statements SQL in MySQL backend
  • Add a parameter in sink-uri to control whether multi statements feature is enabled.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Support multi statements SQL in mysql backend

@amyangfei amyangfei added the area/ticdc Issues or PRs related to TiCDC. label Feb 28, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei marked this pull request as draft February 28, 2023 09:30
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-integration-test

amyangfei
amyangfei commented Mar 1, 2023
View reviewed changes
pkg/sink/mysql/db_helper.go Outdated Show resolved Hide resolved
nongfushanquan
nongfushanquan reviewed Mar 2, 2023
View reviewed changes
cdc/sink/dmlsink/txn/mysql/mysql.go Outdated
cancelFunc()
return err
}
cancelFunc()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why call cancelFunc() here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use defer cancel() now

@amyangfei amyangfei marked this pull request as ready for review March 2, 2023 14:55
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Mar 2, 2023
@amyangfei
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei requested a review from hicqu March 6, 2023 08:21
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
@amyangfei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e2330cc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot merged commit 66ffedd into pingcap:master Mar 15, 2023
@amyangfei amyangfei deleted the support-multi-statements branch March 16, 2023 09:35
@lance6716 lance6716 mentioned this pull request Mar 17, 2023
Merged
12 tasks
amyangfei added a commit to amyangfei/tiflow that referenced this pull request Apr 3, 2023
@amyangfei
sink(ticdc): support multi statements in mysql backend pingcap#8395
47c614e
@amyangfei amyangfei mentioned this pull request Apr 3, 2023
Merged
@nongfushanquan
Copy link
Contributor

/label affects-6.5

ti-chi-bot pushed a commit that referenced this pull request Apr 4, 2023
@amyangfei
cherry pick multi statement sql feature (#8349) (#8395) (#8554) (#8627)…
1090f91 
… (#8731)

ref #8057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@hicqu hicqu hicqu approved these changes

Assignees
No one assigned
Labels
affects-6.5 area/ticdc Issues or PRs related to TiCDC. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @ti-chi-bot @Rustin170506 @nongfushanquan @hicqu